Feature epo 614 #116
Merged
Feature epo 614 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costezki
approved these changes
Oct 27, 2022
| @@ -20,8 +20,7 @@ | |||
| <xd:p>This module defines project level variables and parameters</xd:p> | |||
| </xd:desc> | |||
| </xd:doc> | |||
| <!-- List of xmi files to be merged into a single xmi file--> | |||
| <xsl:variable name="xmiFileList" select="collection('../../test/test-multi-xmi?select=*.xmi')"/> | |||
|
|
|||
There was a problem hiding this comment.
indeed we do not need this
| @@ -14,15 +14,15 @@ | |||
| <prefix name="skos" value="http://www.w3.org/2004/02/skos/core#"/> | |||
|
|
|||
| <prefix name="epo" value="http://data.europa.eu/a4g/ontology#"/> | |||
| <prefix name="epo-not" value="http://data.europa.eu/a4g/ontology#"/> | |||
There was a problem hiding this comment.
good input for the moment.
I fear we will need other namespace definitions too, at least for eOrdering, eFulfillment.
you may as well add them now: "epo-cat", "epo-ful" (same base URI as above)
| @@ -16,6 +16,9 @@ | |||
|
|
|||
| <xsl:import href="../../config/config-proxy.xsl"/> | |||
|
|
|||
| <!-- List of xmi files to be merged into a single xmi file--> | |||
| <xsl:variable name="xmiFileList" select="collection('../../test/test-multi-xmi?select=*.xml')"/> | |||
There was a problem hiding this comment.
why do we want to take XMI files from a "test" location?
This shall not be in the master branch. We need a proper mechanism to indicate where is the input location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.